[dpdk-dev] [PATCH v2 39/41] net/qede: use contiguous allocation for DMA memory

Patil, Harish Harish.Patil at cavium.com
Wed Mar 7 23:55:08 CET 2018


-----Original Message-----
From: Anatoly Burakov <anatoly.burakov at intel.com>
Date: Wednesday, March 7, 2018 at 8:57 AM
To: "dev at dpdk.org" <dev at dpdk.org>
Cc: "Mody, Rasesh" <Rasesh.Mody at cavium.com>, Harish Patil
<Harish.Patil at cavium.com>, "Shaikh, Shahed" <Shahed.Shaikh at cavium.com>,
"keith.wiles at intel.com" <keith.wiles at intel.com>, "jianfeng.tan at intel.com"
<jianfeng.tan at intel.com>, "andras.kovacs at ericsson.com"
<andras.kovacs at ericsson.com>, "laszlo.vadkeri at ericsson.com"
<laszlo.vadkeri at ericsson.com>, "benjamin.walker at intel.com"
<benjamin.walker at intel.com>, "bruce.richardson at intel.com"
<bruce.richardson at intel.com>, "thomas at monjalon.net" <thomas at monjalon.net>,
"konstantin.ananyev at intel.com" <konstantin.ananyev at intel.com>,
"kuralamudhan.ramakrishnan at intel.com"
<kuralamudhan.ramakrishnan at intel.com>, "louise.m.daly at intel.com"
<louise.m.daly at intel.com>, "nelio.laranjeiro at 6wind.com"
<nelio.laranjeiro at 6wind.com>, "yskoh at mellanox.com" <yskoh at mellanox.com>,
"pepperjo at japf.ch" <pepperjo at japf.ch>, "Jacob,  Jerin"
<Jerin.JacobKollanukkaran at cavium.com>, "hemant.agrawal at nxp.com"
<hemant.agrawal at nxp.com>, "olivier.matz at 6wind.com" <olivier.matz at 6wind.com>
Subject: [PATCH v2 39/41] net/qede: use contiguous allocation for DMA
memory

>Signed-off-by: Anatoly Burakov <anatoly.burakov at intel.com>
>---
>
>Notes:
>    Doing "grep -R rte_memzone_reserve drivers/net/qede" returns the
>following:
>    
>    drivers/net/qede/qede_fdir.c:     mz =
>rte_memzone_reserve_aligned(mz_name, QEDE_MAX_FDIR_PKT_LEN,
>    drivers/net/qede/base/bcm_osal.c: mz =
>rte_memzone_reserve_aligned_contig(mz_name, size,
>    drivers/net/qede/base/bcm_osal.c: mz =
>rte_memzone_reserve_aligned_contig(mz_name, size, socket_id, 0,
>    
>    I took a brief look at memzone in qede_fdir and it didn't look like
>memzone
>    was used for DMA, so i left it alone. Corrections welcome.

That’s right.
>
> drivers/net/qede/base/bcm_osal.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/qede/base/bcm_osal.c
>b/drivers/net/qede/base/bcm_osal.c
>index fe42f32..707d553 100644
>--- a/drivers/net/qede/base/bcm_osal.c
>+++ b/drivers/net/qede/base/bcm_osal.c
>@@ -135,7 +135,7 @@ void *osal_dma_alloc_coherent(struct ecore_dev *p_dev,
> 	if (core_id == (unsigned int)LCORE_ID_ANY)
> 		core_id = 0;
> 	socket_id = rte_lcore_to_socket_id(core_id);
>-	mz = rte_memzone_reserve_aligned(mz_name, size,
>+	mz = rte_memzone_reserve_aligned_contig(mz_name, size,
> 					 socket_id, 0, RTE_CACHE_LINE_SIZE);
> 	if (!mz) {
> 		DP_ERR(p_dev, "Unable to allocate DMA memory "
>@@ -174,7 +174,8 @@ void *osal_dma_alloc_coherent_aligned(struct
>ecore_dev *p_dev,
> 	if (core_id == (unsigned int)LCORE_ID_ANY)
> 		core_id = 0;
> 	socket_id = rte_lcore_to_socket_id(core_id);
>-	mz = rte_memzone_reserve_aligned(mz_name, size, socket_id, 0, align);
>+	mz = rte_memzone_reserve_aligned_contig(mz_name, size, socket_id, 0,
>+			align);
> 	if (!mz) {
> 		DP_ERR(p_dev, "Unable to allocate DMA memory "
> 		       "of size %zu bytes - %s\n",
>-- 
>2.7.4

Acked-by: Harish Patil <harish.patil at cavium.com>

>



More information about the dev mailing list