[dpdk-dev] [PATCH v2] drivers/i40e: fix link update no wait

Eelco Chaudron echaudro at redhat.com
Thu Mar 8 14:01:57 CET 2018


On 08/03/18 13:17, Fan Zhang wrote:
> Fixes: 263333bbb7a9 ("i40e: fix link status timeout")
> Cc: cunming.liang at intel.com
> Cc: stable at dpdk.org
>
> In i40e_dev_link_update() the driver obtains the link status
> info via admin queue command despite of "no_wait" flag. This
> requires relatively long time and may be a problem to some
> application such as ovs-dpdk
> (https://bugzilla.redhat.com/show_bug.cgi?id=1551761).
>
> This patch aims to fix the problem by using a different
> approach of obtaining link status for i40e NIC without waiting.
> Instead of getting the link status via admin queue command,
> this patch reads the link status registers to accelerate the
> procedure.
Reviewed the changes, and tested them in combination with Open vSwitch 
bonds/direct interfaces through various VMs and found no problems. Also 
tested basic link flapping.

Reviewed-by: Eelco Chaudron <echaudro at redhat.com>
Tested-by: Eelco Chaudron <echaudro at redhat.com>
> Signed-off-by: Fan Zhang <roy.fan.zhang at intel.com>
> Signed-off-by: Andrey Chilikin <andrey.chilikin at intel.com>
> ---
> v2:
> - add ccs after fixline
>
> <SNIP>




More information about the dev mailing list