[dpdk-dev] [PATCH v4] ethdev: return named opaque type instead of void pointer

Neil Horman nhorman at tuxdriver.com
Fri Mar 9 13:36:51 CET 2018


On Fri, Mar 09, 2018 at 11:25:31AM +0000, Ferruh Yigit wrote:
> "struct rte_eth_rxtx_callback" is defined as internal data structure and
> used as named opaque type.
> 
> So the functions that are adding callbacks can return objects in this
> type instead of void pointer.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
> Acked-by: Stephen Hemminger <stephen at networkplumber.org>
> ---
> v2:
> * keep using struct * in parameters, instead add callback functions
> return struct rte_eth_rxtx_callback pointer.
> 
> v4:
> * Remove deprecation notice. LIBABIVER already increased in this release
> ---
>  doc/guides/rel_notes/deprecation.rst |  7 -------
>  lib/librte_ether/rte_ethdev.c        |  6 +++---
>  lib/librte_ether/rte_ethdev.h        | 13 ++++++++-----
>  3 files changed, 11 insertions(+), 15 deletions(-)
> 
This doesn't quite make sense to me.  If rte_eth_rxtx_callback is defined as an
internal data structure, then it shouldn't be used as part of the prototype for
an exported function, as the structure will then no longer be a internal data
structure, but rather part of the public ABI.

Neil


More information about the dev mailing list