[dpdk-dev] [PATCH v7 3/7] eventtimer: add default software driver

Carrillo, Erik G erik.g.carrillo at intel.com
Mon Mar 12 22:20:14 CET 2018


Hi Jerin,

Response in-line:

> -----Original Message-----
> From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com]
> Sent: Monday, March 12, 2018 3:46 AM
> To: Carrillo, Erik G <erik.g.carrillo at intel.com>
> Cc: pbhagavatula at caviumnetworks.com; dev at dpdk.org;
> nipun.gupta at nxp.com; hemant.agrawal at nxp.com
> Subject: Re: [PATCH v7 3/7] eventtimer: add default software driver
> 
> -----Original Message-----
> > Date: Thu, 8 Mar 2018 15:54:02 -0600
> > From: Erik Gabriel Carrillo <erik.g.carrillo at intel.com>
> > To: pbhagavatula at caviumnetworks.com
> > CC: dev at dpdk.org, jerin.jacob at caviumnetworks.com,
> nipun.gupta at nxp.com,
> > hemant.agrawal at nxp.com
> > Subject: [PATCH v7 3/7] eventtimer: add default software driver
> > X-Mailer: git-send-email 1.7.10
> >
> > If an eventdev PMD does not wish to provide event timer adapter ops
> > definitions, the library will fall back to a default software
> > implementation whose entry points are added by this commit.
> >

<... snipped ...>

> > --- a/mk/rte.app.mk
> > +++ b/mk/rte.app.mk
> > @@ -80,7 +80,6 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_BITRATE)        += -
> lrte_bitratestats
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_LATENCY_STATS)  += -lrte_latencystats
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_POWER)          += -lrte_power
> >
> > -_LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER)          += -lrte_timer
> 
> Any specific reason for this change, if yes, Please create a separate patch for
> the common code change, This will help to review

Yes, I needed to move the rte_timer lib past the eventdev lib in order for the 
static build to complete (since the event timer adapter references symbols from the 
rte_timer lib).  I'll separate that change out in the next series.

Thanks,
Gabriel

> 
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_EFD)            += -lrte_efd
> >
> >  _LDLIBS-y += --whole-archive
> > @@ -98,6 +97,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_CRYPTODEV)      += -
> lrte_cryptodev
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_SECURITY)       += -lrte_security
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_EVENTDEV)       += -lrte_eventdev
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_RAWDEV)         += -lrte_rawdev
> > +_LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER)          += -lrte_timer
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_MEMPOOL)        += -lrte_mempool
> >  _LDLIBS-$(CONFIG_RTE_DRIVER_MEMPOOL_RING)   += -
> lrte_mempool_ring
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_RING)           += -lrte_ring
> > --
> > 2.6.4
> >


More information about the dev mailing list