[dpdk-dev] [PATCH v2 2/2] octeontx: move mbox to common folder

Pavan Nikhilesh pbhagavatula at caviumnetworks.com
Tue Mar 20 17:00:40 CET 2018


Hi Hemant,

On Tue, Mar 20, 2018 at 08:31:42PM +0530, Hemant Agrawal wrote:
>
> HI Pavan,
>     One quick comment
>
> On 3/20/2018 8:10 PM, Pavan Nikhilesh wrote:
> > -LDLIBS += -lrte_eal -lrte_eventdev -lrte_mempool_octeontx -lrte_pmd_octeontx
> > +LDLIBS += -lrte_eal -lrte_eventdev -lrte_octeontx_common -lrte_pmd_octeontx
> Typically the naming convention for driver based libraries is
> "rte_type_specific" e.g. rte_mempool_octeontx.
> rte_octeontx_common is breaking the tradition.

Currently, meson uses that scheme where as traditional make uses
rte_mempool_octeontx style. I will change it to rte_common_octeontx for
traditional make in v3.

<meson>
config_flag_fmt = 'RTE_LIBRTE_ at 0@_MEMPOOL'
driver_name_fmt = 'rte_mempool_ at 0@'

>
> Regards,
> Hemant

Thanks,
Pavan.


More information about the dev mailing list