[dpdk-dev] [PATCH v2 1/3] eal/vfio: add support for multiple container
Thomas Monjalon
thomas at monjalon.net
Wed Mar 21 21:32:18 CET 2018
Hi,
21/03/2018 14:21, Xiao Wang:
> +#endif /* VFIO_PRESENT */
> #endif /* _RTE_VFIO_H_ */
Please keep the empty line which was present between endif.
> + rte_vfio_create_container;
> + rte_vfio_destroy_container;
> + rte_vfio_bind_group_no;
> + rte_vfio_unbind_group_no;
> + rte_vfio_dma_map;
> + rte_vfio_dma_unmap;
> + rte_vfio_get_group_fd;
Please keep alphabetical order.
About the naming, I see "no" and "idx" are used.
Other APIs in DPDK are using "num" and "id". Any strong opinion?
More information about the dev
mailing list