[dpdk-dev] [PATCH] net/octeontx: use the new offload APIs
Shahaf Shuler
shahafs at mellanox.com
Thu Mar 22 07:26:04 CET 2018
Wednesday, March 21, 2018 9:26 PM, Ferruh Yigit:
> Subject: Re: [dpdk-dev] [PATCH] net/octeontx: use the new offload APIs
>
> > +
> > + if (configured_offloads & DEV_RX_OFFLOAD_CHECKSUM) {
> > + PMD_INIT_LOG(NOTICE, "rxcksum not supported");
> > + configured_offloads &= ~DEV_RX_OFFLOAD_CHECKSUM;
> > + }
>
> Not sure about changing the application configuration, and since this offload
> is not reported as supported application should not set it, if it does this
> should return an error.
Yes, any wrong offload configuration should fail the port/queue configuration with the proper error logging.
PMDs should not silently adopt to wrong configuration. This might lead the application to believe Rx checksum offload was enabled.
More information about the dev
mailing list