[dpdk-dev] [PATCH v1] bus/fslmc: fix find device start condition

Shreyansh Jain shreyansh.jain at nxp.com
Fri Mar 23 09:52:13 CET 2018


On Thu, Mar 22, 2018 at 3:58 PM, Gaetan Rivet <gaetan.rivet at 6wind.com> wrote:
> If start is set and a device before it matches the data,
> this device is returned.
>
> Fixes: c7fe1eea8a74 ("bus: simplify finding starting point")
> Cc: stable at dpdk.org
>
> Cc: Hemant Agrawal <hemant.agrawal at nxp.com>
> Cc: Shreyansh Jain <shreyansh.jain at nxp.com>
> Signed-off-by: Gaetan Rivet <gaetan.rivet at 6wind.com>
> ---
>
> Hi Shreyansh, Hemant,
>
> Sorry, I did not test this.
> I found this issue while working on vdev and PCI.
>
> There is a better way to iterate on devices [1], but the gain
> is really minimal and the implementation slightly more complex.
> I preferred to avoid complex, as I could not test this patch.
>
> Regards,
>
> [1]: http://dpdk.org/ml/archives/dev/2018-March/092906.html
>

I think this change should suffice here. Thanks.

(On a side note, it seems compilation using clang is failing for this
patch [1] though it is not related to this change. I will look into
that)

[1] http://dpdk.org/ml/archives/test-report/2018-March/044684.html

Acked-by: Shreyansh Jain <shreyansh.jain at nxp.com>


More information about the dev mailing list