[dpdk-dev] [PATCH] ethdev: fix queue start

Ananyev, Konstantin konstantin.ananyev at intel.com
Sat Mar 24 13:06:55 CET 2018



> 
> Device must be started before start any queue.
> 
> Fixes: 0748be2cf9a2 ("ethdev: queue start and stop")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Qi Zhang <qi.z.zhang at intel.com>
> ---
>  lib/librte_ether/rte_ethdev.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
> index 0590f0c10..7aa404fa5 100644
> --- a/lib/librte_ether/rte_ethdev.c
> +++ b/lib/librte_ether/rte_ethdev.c
> @@ -732,6 +732,12 @@ rte_eth_dev_rx_queue_start(uint16_t port_id, uint16_t rx_queue_id)
>  	RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -EINVAL);
> 
>  	dev = &rte_eth_devices[port_id];
> +	if (!dev->data->dev_started) {
> +		RTE_PMD_DEBUG_TRACE(
> +		    "port %d must be started before start any queue\n", port_id);
> +		return -EINVAL;
> +	}
> +
>  	if (rx_queue_id >= dev->data->nb_rx_queues) {
>  		RTE_PMD_DEBUG_TRACE("Invalid RX queue_id=%d\n", rx_queue_id);
>  		return -EINVAL;
> @@ -785,6 +791,12 @@ rte_eth_dev_tx_queue_start(uint16_t port_id, uint16_t tx_queue_id)
>  	RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -EINVAL);
> 
>  	dev = &rte_eth_devices[port_id];
> +	if (!dev->data->dev_started) {
> +		RTE_PMD_DEBUG_TRACE(
> +		    "port %d must be started before start any queue\n", port_id);
> +		return -EINVAL;
> +	}
> +
>  	if (tx_queue_id >= dev->data->nb_tx_queues) {
>  		RTE_PMD_DEBUG_TRACE("Invalid TX queue_id=%d\n", tx_queue_id);
>  		return -EINVAL;
> --

Acked-by: Konstantin Ananyev <konstantin.ananyev at intel.com>

> 2.13.6



More information about the dev mailing list