[dpdk-dev] [PATCH] compressdev: implement API

[Trahe, Fiona]

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas at monjalon.net]
> Sent: Saturday, March 24, 2018 1:02 AM
> To: Trahe, Fiona <fiona.trahe at intel.com>
> Cc: dev at dpdk.org; ahmed.mansour at nxp.com; Shally.Verma at cavium.com; De Lara Guarch, Pablo
> <pablo.de.lara.guarch at intel.com>; fiona.trahe at gmail.com
> Subject: Re: [dpdk-dev] [PATCH] compressdev: implement API
> 
> 23/03/2018 19:08, Trahe, Fiona:
> > From: Thomas Monjalon [mailto:thomas at monjalon.net]
> > > 02/02/2018 19:25, Fiona Trahe:
> > > >  lib/librte_compressdev/rte_comp.h                  | 503 ++++++++++++
> > >
> > > Why rte_comp.h instead of the more consistent rte_compress.h?
> > [Fiona]  I did originally... but ran into difficulty with horribly names like
> > RTE_COMPRESS_COMPRESS
> > RTE_COMPRESS_DECOMPRESS
> > rte_compress_compress_xform
> > rte_compress_decompress_xform
> > So compress is both the module prefix and the name of one of the actions.
> > I could have used compressdev - but names were very long.
> > So decided to opt for using
> > _compressdev_ in names to do with the device and
> > _comp_ in names to do with the compression service
> >
> > Also I could have used compdev instead of compressdev,
> > but I felt compress should be in the lib name
> 
> I understand your concerns.
> I don't like "comp" very much because it sounds like "comparison".
> However, I don't have a better idea.
> Sometimes naming is more difficult than coding :)
[Fiona] True :)