[dpdk-dev] [PATCH v3 5/7] cryptodev: add document for virtio crypto PMD

Zhoujian (jay) jianjay.zhou at huawei.com
Fri Mar 30 08:36:11 CEST 2018



> -----Original Message-----
> From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch at intel.com]
> Sent: Friday, March 30, 2018 6:36 AM
> To: Zhoujian (jay) <jianjay.zhou at huawei.com>; dev at dpdk.org
> Cc: Zhang, Roy Fan <roy.fan.zhang at intel.com>; thomas at monjalon.net; Gonglei
> (Arei) <arei.gonglei at huawei.com>; Zeng, Xin <xin.zeng at intel.com>;
> Huangweidong (C) <weidong.huang at huawei.com>; wangxin (U)
> <wangxinxin.wang at huawei.com>; longpeng <longpeng2 at huawei.com>
> Subject: RE: [PATCH v3 5/7] cryptodev: add document for virtio crypto PMD
> 
> 
> 
> > -----Original Message-----
> > From: Jay Zhou [mailto:jianjay.zhou at huawei.com]
> > Sent: Sunday, March 25, 2018 9:34 AM
> > To: dev at dpdk.org
> > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>; Zhang, Roy
> > Fan <roy.fan.zhang at intel.com>; thomas at monjalon.net;
> > arei.gonglei at huawei.com; Zeng, Xin <xin.zeng at intel.com>;
> > weidong.huang at huawei.com; wangxinxin.wang at huawei.com;
> > longpeng2 at huawei.com; jianjay.zhou at huawei.com
> > Subject: [PATCH v3 5/7] cryptodev: add document for virtio crypto PMD
> 
> You should use "doc: add virtio crypto PMD guide"

Okay.

> 
> >
> > Signed-off-by: Jay Zhou <jianjay.zhou at huawei.com>
> > ---
> >  doc/guides/cryptodevs/features/virtio.ini |  22 ++++++
> >  doc/guides/cryptodevs/virtio.rst          | 117
> 
> I tried building the documentation and it fails:
> 
> Warning generate_overview_table(): File 'virtio.ini' has no [AEAD] secton
> /root/dpdk/doc/guides/cryptodevs/virtio.rst: WARNING: document isn't included
> in any toctree
> 
> You should also add a note about this PMD in release notes, but you should
> probably do it in the first patch.
> 

Okay. Will fix all the above.

Regards,
Jay



More information about the dev mailing list