[dpdk-dev] [PATCH v3 2/7] crpyto/virtio: add crypto related session structure

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: Zhoujian (jay) [mailto:jianjay.zhou at huawei.com]
> Sent: Friday, March 30, 2018 3:44 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>;
> dev at dpdk.org
> Cc: Zhang, Roy Fan <roy.fan.zhang at intel.com>; thomas at monjalon.net;
> Gonglei (Arei) <arei.gonglei at huawei.com>; Zeng, Xin
> <xin.zeng at intel.com>; Huangweidong (C) <weidong.huang at huawei.com>;
> wangxin (U) <wangxinxin.wang at huawei.com>; longpeng
> <longpeng2 at huawei.com>
> Subject: RE: [PATCH v3 2/7] crpyto/virtio: add crypto related session
> structure
> 
> 
> 
> > -----Original Message-----
> > From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch at intel.com]
> > Sent: Friday, March 30, 2018 6:12 AM
> > To: Zhoujian (jay) <jianjay.zhou at huawei.com>; dev at dpdk.org
> > Cc: Zhang, Roy Fan <roy.fan.zhang at intel.com>; thomas at monjalon.net;
> > Gonglei
> > (Arei) <arei.gonglei at huawei.com>; Zeng, Xin <xin.zeng at intel.com>;
> > Huangweidong (C) <weidong.huang at huawei.com>; wangxin (U)
> > <wangxinxin.wang at huawei.com>; longpeng <longpeng2 at huawei.com>
> > Subject: RE: [PATCH v3 2/7] crpyto/virtio: add crypto related session
> > structure
> >
> >
> >
> > > -----Original Message-----
> > > From: Jay Zhou [mailto:jianjay.zhou at huawei.com]
> > > Sent: Sunday, March 25, 2018 9:34 AM
> > > To: dev at dpdk.org
> > > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>; Zhang,
> > > Roy Fan <roy.fan.zhang at intel.com>; thomas at monjalon.net;
> > > arei.gonglei at huawei.com; Zeng, Xin <xin.zeng at intel.com>;
> > > weidong.huang at huawei.com; wangxinxin.wang at huawei.com;
> > > longpeng2 at huawei.com; jianjay.zhou at huawei.com
> > > Subject: [PATCH v3 2/7] crpyto/virtio: add crypto related session
> > > structure
> >
> > Typo in title.
> 
> Will fix.
> 
> >
> > >
> > > This structure will be used in the following patches, especially at
> > > creating and destroying crypto sessions.
> > >
> > > Signed-off-by: Jay Zhou <jianjay.zhou at huawei.com>
> > > ---
> > >  drivers/crypto/virtio/virtio_crypto_algs.h | 27
> > > +++++++++++++++++++++++++++
> > >  1 file changed, 27 insertions(+)
> > >  create mode 100644 drivers/crypto/virtio/virtio_crypto_algs.h
> > >
> > > diff --git a/drivers/crypto/virtio/virtio_crypto_algs.h
> > > b/drivers/crypto/virtio/virtio_crypto_algs.h
> > > new file mode 100644
> > > index 0000000..5f1e9df
> > > --- /dev/null
> > > +++ b/drivers/crypto/virtio/virtio_crypto_algs.h
> > > @@ -0,0 +1,27 @@
> > > +/* SPDX-License-Identifier: BSD-3-Clause
> > > + * Copyright(c) 2018 HUAWEI TECHNOLOGIES CO., LTD.
> > > + */
> > > +
> > > +#ifndef _VIRTIO_CRYPTO_ALGS_H_
> > > +#define _VIRTIO_CRYPTO_ALGS_H_
> > > +
> > > +#include <rte_memory.h>
> > > +#include <linux/virtio_crypto.h>
> > > +
> > > +struct virtio_crypto_session {
> > > +	uint64_t session_id;
> >
> > Probably a uint32_t here is enough.
> 
> Consider the type of session_id in the struct virtio_crypto_op_header of
> linux kernel and QEMU side is uint64_t, could we just keep it as uint64_t
> for consistency?

Fair enough.

Pablo

> 
> Regards,
> Jay