[dpdk-dev] [PATCH v2 1/2] net/i40e: fix queue offload initialize

[Zhang, Qi Z]

> -----Original Message-----
> From: Ananyev, Konstantin
> Sent: Wednesday, May 2, 2018 7:29 PM
> To: Zhang, Qi Z <qi.z.zhang at intel.com>; Yigit, Ferruh <ferruh.yigit at intel.com>
> Cc: dev at dpdk.org; Xing, Beilei <beilei.xing at intel.com>
> Subject: RE: [PATCH v2 1/2] net/i40e: fix queue offload initialize
> 
> 
> 
> > -----Original Message-----
> > From: Zhang, Qi Z
> > Sent: Wednesday, May 2, 2018 4:57 AM
> > To: Yigit, Ferruh <ferruh.yigit at intel.com>; Ananyev, Konstantin
> > <konstantin.ananyev at intel.com>
> > Cc: dev at dpdk.org; Xing, Beilei <beilei.xing at intel.com>; Zhang, Qi Z
> > <qi.z.zhang at intel.com>
> > Subject: [PATCH v2 1/2] net/i40e: fix queue offload initialize
> >
> > Add missing queue offload initialization.
> >
> > Fixes: 7497d3e2f777 ("net/i40e: convert to new Tx offloads API")
> > Fixes: c3ac7c5b0b8a ("net/i40e: convert to new Rx offloads API")
> >
> > Signed-off-by: Qi Zhang <qi.z.zhang at intel.com>
> > ---
> >
> > v2:
> > - add missing part in i40e_vf_represent.
> >
> >  drivers/net/i40e/i40e_ethdev.c         | 1 +
> >  drivers/net/i40e/i40e_ethdev_vf.c      | 1 +
> >  drivers/net/i40e/i40e_rxtx.c           | 2 ++
> >  drivers/net/i40e/i40e_vf_representor.c | 2 ++
> >  4 files changed, 6 insertions(+)
> >
> > diff --git a/drivers/net/i40e/i40e_ethdev.c
> > b/drivers/net/i40e/i40e_ethdev.c index 284e9cb64..a001d5b99 100644
> > --- a/drivers/net/i40e/i40e_ethdev.c
> > +++ b/drivers/net/i40e/i40e_ethdev.c
> > @@ -3345,6 +3345,7 @@ i40e_dev_info_get(struct rte_eth_dev *dev,
> struct rte_eth_dev_info *dev_info)
> >  		.tx_rs_thresh = I40E_DEFAULT_TX_RSBIT_THRESH,
> >  		.txq_flags = ETH_TXQ_FLAGS_NOMULTSEGS |
> >  				ETH_TXQ_FLAGS_NOOFFLOADS,
> > +		.offloads = 0,
> >  	};
> >
> >  	dev_info->rx_desc_lim = (struct rte_eth_desc_lim) { diff --git
> > a/drivers/net/i40e/i40e_ethdev_vf.c
> > b/drivers/net/i40e/i40e_ethdev_vf.c
> > index 48e7ac21e..de5f460e9 100644
> > --- a/drivers/net/i40e/i40e_ethdev_vf.c
> > +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> > @@ -2238,6 +2238,7 @@ i40evf_dev_info_get(struct rte_eth_dev *dev,
> struct rte_eth_dev_info *dev_info)
> >  		.tx_rs_thresh = I40E_DEFAULT_TX_RSBIT_THRESH,
> >  		.txq_flags = ETH_TXQ_FLAGS_NOMULTSEGS |
> >  				ETH_TXQ_FLAGS_NOOFFLOADS,
> > +		.offloads = 0,
> >  	};
> >
> >  	dev_info->rx_desc_lim = (struct rte_eth_desc_lim) { diff --git
> > a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index
> > 006f5b846..755109ee5 100644
> > --- a/drivers/net/i40e/i40e_rxtx.c
> > +++ b/drivers/net/i40e/i40e_rxtx.c
> > @@ -1857,6 +1857,7 @@ i40e_dev_rx_queue_setup(struct rte_eth_dev
> *dev,
> >  	rxq->drop_en = rx_conf->rx_drop_en;
> >  	rxq->vsi = vsi;
> >  	rxq->rx_deferred_start = rx_conf->rx_deferred_start;
> > +	rxq->offloads = rx_conf->offloads;
> >
> >  	/* Allocate the maximun number of RX ring hardware descriptor. */
> >  	len = I40E_MAX_RING_DESC;
> > @@ -2297,6 +2298,7 @@ i40e_dev_tx_queue_setup(struct rte_eth_dev
> *dev,
> >  	txq->reg_idx = reg_idx;
> >  	txq->port_id = dev->data->port_id;
> >  	txq->txq_flags = tx_conf->txq_flags;
> > +	txq->offloads = tx_conf->offloads;
> >  	txq->vsi = vsi;
> >  	txq->tx_deferred_start = tx_conf->tx_deferred_start;
> >
> 
> Looks ok, but I think you forgot to:
> qinfo->conf.offloads = txq->offloads;
> inside i40e_txq_info_get()
> Konstantin

Yes, will add this.

> 
> > diff --git a/drivers/net/i40e/i40e_vf_representor.c
> > b/drivers/net/i40e/i40e_vf_representor.c
> > index a8aa0115d..95c6696b8 100644
> > --- a/drivers/net/i40e/i40e_vf_representor.c
> > +++ b/drivers/net/i40e/i40e_vf_representor.c
> > @@ -69,6 +69,7 @@ i40e_vf_representor_dev_infos_get(struct
> rte_eth_dev *ethdev,
> >  		},
> >  		.rx_free_thresh = I40E_DEFAULT_RX_FREE_THRESH,
> >  		.rx_drop_en = 0,
> > +		.offloads = 0,
> >  	};
> >
> >  	dev_info->default_txconf = (struct rte_eth_txconf) { @@ -81,6 +82,7
> > @@ i40e_vf_representor_dev_infos_get(struct rte_eth_dev *ethdev,
> >  		.tx_rs_thresh = I40E_DEFAULT_TX_RSBIT_THRESH,
> >  		.txq_flags = ETH_TXQ_FLAGS_NOMULTSEGS |
> >  				ETH_TXQ_FLAGS_NOOFFLOADS,
> > +		.offloads = 0,
> >  	};
> >
> >  	dev_info->rx_desc_lim = (struct rte_eth_desc_lim) {
> > --
> > 2.13.6