[dpdk-dev] [PATCH] net/i40e: fix flow RSS key array error

[Zhang, Qi Z]

> -----Original Message-----
> From: Zhao1, Wei
> Sent: Monday, May 7, 2018 1:34 PM
> To: dev at dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang at intel.com>; adrien.mazarguil at 6wind.com; Zhao1,
> Wei <wei.zhao1 at intel.com>
> Subject: [PATCH] net/i40e: fix flow RSS key array error
> 
> This is a bug introduced into RSS key array span.
> 
> Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow API")

Is this correct fix line? Looks like a bug already exist at beginning. Below definition is obviously wrong

        uint8_t key[(I40E_VFQF_HKEY_MAX_INDEX > I40E_PFQF_HKEY_MAX_INDEX ?
                     I40E_VFQF_HKEY_MAX_INDEX : I40E_PFQF_HKEY_MAX_INDEX) + 1 *
                    sizeof(uint32_t)]; /* Hash key. */

> Signed-off-by: Wei Zhao <wei.zhao1 at intel.com>
> ---
>  drivers/net/i40e/i40e_ethdev.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/i40e/i40e_ethdev.h b/drivers/net/i40e/i40e_ethdev.h
> index 2cccc4f..4dd50eb 100644
> --- a/drivers/net/i40e/i40e_ethdev.h
> +++ b/drivers/net/i40e/i40e_ethdev.h
> @@ -886,7 +886,7 @@ struct i40e_rte_flow_rss_conf {
>  	struct rte_flow_action_rss conf; /**< RSS parameters. */
>  	uint16_t queue_region_conf; /**< Queue region config flag */
>  	uint8_t key[(I40E_VFQF_HKEY_MAX_INDEX >
> I40E_PFQF_HKEY_MAX_INDEX ?
> -		     I40E_VFQF_HKEY_MAX_INDEX : I40E_PFQF_HKEY_MAX_INDEX)
> + 1 *
> +		     I40E_VFQF_HKEY_MAX_INDEX : I40E_PFQF_HKEY_MAX_INDEX
> + 1) *
>  		    sizeof(uint32_t)]; /* Hash key. */
>  	uint16_t queue[I40E_MAX_Q_PER_TC]; /**< Queues indices to use. */  };
> --
> 2.7.5