[dpdk-dev] [PATCH v8] ethdev: check Rx/Tx offloads

Andrew Rybchenko arybchenko at solarflare.com
Tue May 8 12:41:26 CEST 2018


On 05/08/2018 01:05 PM, Wei Dai wrote:

[...]

> In the beginning of [rt]x_queue_setup( ) of underlying PMD,
> add offloads = [rt]xconf->offloads |
> dev->data->dev_conf.[rt]xmode.offloads; to keep same as offload API
> defined in 17.11 to avoid upper application broken due to offload
> API change.
> PMD can use the info that input [rt]xconf->offloads only carry
> the new added per-queue offloads to do some optimization or some
> code change on base of this patch.

It looks like I've missed why PMDs should be updated to
add device offloads to per-queue offloads.
Cannot it be done on ethdev layer? PMD still can find out
which offloads were enabled on device level by
checking [rt]xmode->offlaods.

> Signed-off-by: Wei Dai <wei.dai at intel.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
> Signed-off-by: Qi Zhang <qi.z.zhang at intel.com>

[...]


More information about the dev mailing list