[dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated.

Dumitrescu, Cristian cristian.dumitrescu at intel.com
Tue May 8 16:27:54 CEST 2018



> -----Original Message-----
> From: Zhang, Roy Fan
> Sent: Monday, April 16, 2018 11:26 AM
> To: dev at dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu at intel.com>; Singh, Jasvinder
> <jasvinder.singh at intel.com>
> Subject: [PATCH] examples/ip_pipeline: fix buffer not null terminated.
> 
> Coverity issue: 272563
> Fixes: 8245472c58c8 ("examples/ip_pipeline: add sw queue object")
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang at intel.com>
> ---
>  examples/ip_pipeline/swq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/examples/ip_pipeline/swq.c b/examples/ip_pipeline/swq.c
> index c11bbf27e..be78704c1 100644
> --- a/examples/ip_pipeline/swq.c
> +++ b/examples/ip_pipeline/swq.c
> @@ -64,7 +64,7 @@ swq_create(const char *name, struct swq_params
> *params)
>  	}
> 
>  	/* Node fill in */
> -	strncpy(swq->name, name, sizeof(swq->name));
> +	strncpy(swq->name, name, sizeof(swq->name) - 1);
>  	swq->r = r;
> 
>  	/* Node add to list */
> --
> 2.13.6

Acked-by: Cristian.Dumitrescu <cristian.dumitrescu at intel.com>

Applied to next-pipeline tree, thanks!



More information about the dev mailing list