[dpdk-dev] [PATCH v9 1/4] bus/ifpga: Add Intel FPGA BUS Library

[Xu, Rosen]

Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas at monjalon.net]
> Sent: Tuesday, May 08, 2018 22:43
> To: Xu, Rosen <rosen.xu at intel.com>
> Cc: dev at dpdk.org; Doherty, Declan <declan.doherty at intel.com>;
> Richardson, Bruce <bruce.richardson at intel.com>; shreyansh.jain at nxp.com;
> Yigit, Ferruh <ferruh.yigit at intel.com>; Ananyev, Konstantin
> <konstantin.ananyev at intel.com>; Zhang, Tianfei <tianfei.zhang at intel.com>;
> Liu, Song <song.liu at intel.com>; Wu, Hao <hao.wu at intel.com>;
> gaetan.rivet at 6wind.com
> Subject: Re: [PATCH v9 1/4] bus/ifpga: Add Intel FPGA BUS Library
> 
> 08/05/2018 16:19, Xu, Rosen:
> > --- /dev/null
> > +++ b/drivers/bus/ifpga/rte_bus_ifpga_version.map
> > +	ifpga_get_integer32_arg;
> > +	ifpga_get_string_arg;
> > +	rte_ifpga_driver_register;
> > +	rte_ifpga_driver_unregister;
> 
> All exported symbols must start with rte_

I will fix it in v10.

> 
> > --- a/drivers/bus/meson.build
> > +++ b/drivers/bus/meson.build
> > -drivers = ['dpaa', 'fslmc', 'pci', 'vdev']
> > +drivers = ['dpaa', 'fslmc', 'pci', 'vdev', 'ifpga']
> 
> Would be better sorted in alphabetical order (between fslmc and pci).
> Same comment in files config/common_base and drivers/bus/Makefile.

I will fix in in v10.