[dpdk-dev] [PATCH v2 2/6] lib/cryptodev: add asym op support in cryptodev

Verma, Shally Shally.Verma at cavium.com
Wed May 9 09:33:32 CEST 2018



>-----Original Message-----
>From: Trahe, Fiona [mailto:fiona.trahe at intel.com]
>Sent: 08 May 2018 20:14
>To: Verma, Shally <Shally.Verma at cavium.com>; De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>
>Cc: Doherty, Declan <declan.doherty at intel.com>; Athreya, Narayana Prasad <NarayanaPrasad.Athreya at cavium.com>; Sahu, Sunila
><Sunila.Sahu at cavium.com>; Gupta, Ashish <Ashish.Gupta at cavium.com>; dev at dpdk.org; Sahu, Sunila <Sunila.Sahu at cavium.com>;
>Gupta, Ashish <Ashish.Gupta at cavium.com>
>Subject: RE: [PATCH v2 2/6] lib/cryptodev: add asym op support in cryptodev
>
>Hi Shally,
>
>
>> -----Original Message-----
>> From: Shally Verma [mailto:shally.verma at caviumnetworks.com]
>> Sent: Thursday, April 5, 2018 12:25 PM
>> To: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>
>> Cc: Doherty, Declan <declan.doherty at intel.com>; Trahe, Fiona <fiona.trahe at intel.com>;
>> pathreya at caviumnetworks.com; ssahu at caviumnetworks.com; agupta at caviumnetworks.com;
>> dev at dpdk.org; Sunila Sahu <sunila.sahu at caviumnetworks.com>; Ashish Gupta
>> <ashish.gupta at caviumnetworks.com>
>> Subject: [PATCH v2 2/6] lib/cryptodev: add asym op support in cryptodev
>>
>>  struct rte_cryptodev_sym_session *
>>  rte_cryptodev_sym_session_create(struct rte_mempool *mp)
>>  {
>>  	struct rte_cryptodev_sym_session *sess;
>>
>>  	/* Allocate a session structure from the session pool */
>> -	if (rte_mempool_get(mp, (void **)&sess)) {
>> +	if (rte_mempool_get(mp, (void *)&sess)) {
>[Fiona] Are you introducing a bug here?
>The fn expects a void **
[Shally] Ya. My bad. Missed it.

>Also this will need rebasing - the latest code has an extra byte.



More information about the dev mailing list