[dpdk-dev] [PATCH v1] doc: add mlx4 CRC stripping toggling limitation

[Ophir Munk]

Sure. Agreed.

Regards,
Ophir

> -----Original Message-----
> From: Shahaf Shuler
> Sent: Wednesday, May 09, 2018 1:07 PM
> To: Thomas Monjalon <thomas at monjalon.net>; Ophir Munk
> <ophirmu at mellanox.com>
> Cc: dev at dpdk.org; Adrien Mazarguil <adrien.mazarguil at 6wind.com>; Olga
> Shern <olgas at mellanox.com>
> Subject: RE: [PATCH v1] doc: add mlx4 CRC stripping toggling limitation
> 
> Tuesday, May 8, 2018 3:34 PM, Thomas Monjalon:
> > Subject: Re: [PATCH v1] doc: add mlx4 CRC stripping toggling limitation
> >
> > 08/05/2018 14:30, Ophir Munk:
> > > +Limitations
> > > +-----------
> > > +
> > > +- CRC stripping is supported by default and this capability is always
> > reported
> > > +  as "true". The ability to enable/disable CRC stripping requires OFED
> > version
> > > +  4.3-1.5.0.0 or rdma-core version v18.
> >
> > I think it is better to merge this patch with the one fixing the capability.
> > So we will be able to refer to one atomic commit in the history.
> >
> 
> If you agree Ophir I will squash the two patch into one and merge it on mlx4.
> OK?