[dpdk-dev] [PATCH v1 1/1] service: Add service lcore attr APIs

Van Haaren, Harry harry.van.haaren at intel.com
Wed May 9 17:19:05 CEST 2018


> -----Original Message-----
> From: Carrillo, Erik G
> Sent: Friday, May 4, 2018 9:16 PM
> To: Van Haaren, Harry <harry.van.haaren at intel.com>
> Cc: jerin.jacob at caviumnetworks.com; Vangati, Narender
> <narender.vangati at intel.com>; Eads, Gage <gage.eads at intel.com>; dev at dpdk.org
> Subject: [PATCH v1 1/1] service: Add service lcore attr APIs
> 
> Add a counter that gets bumped each time the service runner loop goes
> around, and APIs to query and reset the attribute values.
> 
> Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo at intel.com>

>From cover letter for this patch:

This patch proposes the addition of an API which allows an application to
query the attributes of a service lcore.  It adds one such new attribute,
named "loops", which is a counter that tracks the number of times the service
core has looped in the service runner function (the driver function that
invokes services mapped to a service core).  This is useful to applications
that desire a "liveness" check to make sure a service core is not stuck.


When sending a single patch it is not required to send with --cover-letter.

I like the description provided in the cover letter, perhaps merge the
current commit message with the cover-letter paragraph?

For the v2, please include

Acked-by: Harry van Haaren <harry.van.haaren at intel.com>




More information about the dev mailing list