[dpdk-dev] [PATCH v2 00/11] ethdev: fix race conditions in iterator and notifications

Gaëtan Rivet gaetan.rivet at 6wind.com
Thu May 10 18:23:06 CEST 2018


Hello Thomas,

On Thu, May 10, 2018 at 12:43:02AM +0200, Thomas Monjalon wrote:
> We have discovered some race conditions when using the port iterator
> and/or the notifications recently added.
> The work was done mostly with failsafe but some bugs could
> be reproduced with other drivers.
> These 11 patches are fixing all these issues.
> The PMDs are modified to call a new function after probing each port.
> 
> v2 (address Gaetan comments):
> * rename rte_eth_dev_allocated_lock_free to rte_eth_dev_allocated_nolock
> * do not use uint32_t for avoiding port id iteration overflow
>   (should be fixed separately with BUILD_BUG_ON)
> 
> 
> Quick survey:
> Do you think it is too late to merge these fixes in 18.05?
> Or do you agree that these bugs really deserve to be fixed
> by this series in 18.05-rc3?
> 

I'm usually of the opinion that it is almost never too late, so I vote
for including this series in rc3.

-- 
Gaëtan Rivet
6WIND


More information about the dev mailing list