[dpdk-dev] [PATCH] net/i40e: fix missing Port Representor data-path callbacks
Remy Horton
remy.horton at intel.com
Fri May 11 14:29:04 CEST 2018
On 11/05/2018 11:48, Mohammad Abdul Awal wrote:
[..]
>> +static uint16_t
>> +i40e_vf_representor_tx_burst(__rte_unused void *tx_queue,
>> + struct rte_mbuf **tx_pkts,
>> + uint16_t nb_pkts)
>> +{
>> + uint16_t idx_pkt;
>> +
>> + for (idx_pkt = 0; idx_pkt < nb_pkts; idx_pkt++)
>> + rte_pktmbuf_free(tx_pkts[idx_pkt]);
> We should not free them in the driver silently whereas the application
> will think that it has been sent successfully.
> Please use the same rule for rx_burst, and return 0.
Ok, v2 coming.
I'll also combine this and the ixgbe patch into the same patchset.
More information about the dev
mailing list