[dpdk-dev] [PATCH] app/testpmd: check if CRC strip offload supported

[Iremonger, Bernard]

> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Shahaf Shuler
> Sent: Thursday, May 10, 2018 5:39 AM
> To: Yigit, Ferruh <ferruh.yigit at intel.com>; Lu, Wenzhuo
> <wenzhuo.lu at intel.com>; Wu, Jingjing <jingjing.wu at intel.com>
> Cc: dev at dpdk.org; Dai, Wei <wei.dai at intel.com>; Zhang, Qi Z
> <qi.z.zhang at intel.com>
> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: check if CRC strip offload
> supported
> 
> Thursday, May 10, 2018 1:09 AM, Ferruh Yigit:
> > Subject: [PATCH] app/testpmd: check if CRC strip offload supported
> >
> > Testpmd set CRC_STRIP offload blindly, this is wrong according offload
> > API definition, and will cause error for the PMDs that doesn't support
> > CRC_STRIP like virtual PMDs.
> >
> > Check if underlying device report this capability and don't set it if
> > not supported.
> >
> > Fixes: 0074d02fca21 ("app/testpmd: convert to new Rx offloads API")
> > Cc: shahafs at mellanox.com
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
> 
> Yes this is the correct behavior. I hope all the PMDs report the CRC strip
> correctly.
> 
> Acked-by: Shahaf Shuler < shahafs at mellanox.com>

Acked-by: Bernard Iremonger <Bernard.iremonger at intel.com>