[dpdk-dev] [PATCH v3 01/24] lib/librte_eal: import libbsd strlcpy

[Andy Green]

On 05/13/2018 10:56 PM, Thomas Monjalon wrote:
> Hi,
> 
> 12/05/2018 03:58, Andy Green:
>> Signed-off-by: Andy Green <andy at warmcat.com>
> 
> Why do we need to replace rte_strlcpy fallback?
> GCC 8 complains about the fallback using snprintf?

No; the first version of this patch just fixed the compiler warnings. 
But Stephen Hemminger <stephen at networkplumber.org> requested the ersatz 
rte_strlcpy be replaced --->

> 
>> +/*
>> + * Copyright (c) 1998 Todd C. Miller <Todd.Miller at courtesan.com>
>> + *
>> + * Permission to use, copy, modify, and distribute this software for any
>> + * purpose with or without fee is hereby granted, provided that the above
>> + * copyright notice and this permission notice appear in all copies.
>> + */
>> +
>> +size_t
>> +rte_strlcpy(char *dst, const char *src, size_t siz)
>> +{
> [...]
>> +}
> 
> I would like to be sure there is no legal issue with this imported code.

"with the one from BSD".  If it's OK to use BSD anything then the way 
this is imported should be respecting the original license.

-Andy

> 
> [...]
>> -static inline size_t
>> -rte_strlcpy(char *dst, const char *src, size_t size)
>> -{
>> -	return snprintf(dst, size, "%s", src);
>> -}
>> +size_t
>> +rte_strlcpy(char *dst, const char *src, size_t size);
> 
> 
>