[dpdk-dev] [PATCH v1] net/tap: fix isolation mode toggling

Wiles, Keith keith.wiles at intel.com
Tue May 15 00:28:35 CEST 2018


>> 
>> Using double negation is not very readable IMO, I would prefer this
>> converted to a true boolean type if required.
>> 
> 
> Double negation usage was eliminated. 

Thanks I acked already.

> 
>> variable ‘set' here should a 0 or 1 already, please expand this code to not use
>> !!, using this in modern compilers should not be required. I understand this
>> maybe shorted to write, but not very readable IMO and we need to make
>> DPDK readable.
>> 

Regards,
Keith



More information about the dev mailing list