[dpdk-dev] [PATCH] bus/pci: correct the earlier strlcpy conversion

Thomas Monjalon thomas at monjalon.net
Tue May 15 15:19:58 CEST 2018


15/05/2018 12:51, Andrew Rybchenko:
> On 05/15/2018 10:31 AM, Andy Green wrote:
> > Fixes: fe5f777b5383 ("bus/pci: replace strncpy by strlcpy")
> > Signed-off-by: Andy Green <andy at warmcat.com>
> 
> Reviewed-by: Andrew Rybchenko <arybchenko at solarflare.com>
> 
> Suggest to reword it as:
> 
> bus/pci: fix invalid size of driver name buffer
> 
> Variable dri_name is a pointer and it is incorrect to use its
> size as the buffer size. Caller knows the buffer size and
> it is safer to pass it explicitly.

Applied, thanks





More information about the dev mailing list