[dpdk-dev] [PATCH] eal/service: improve error checking of coremasks

Thomas Monjalon thomas at monjalon.net
Tue May 15 17:38:01 CEST 2018


15/05/2018 16:52, Harry van Haaren:
> +	if (eal_service_cores_parsed())
> +		RTE_LOG(ERR, EAL,
> +			"Warning: Service cores parsed before dataplane cores. Ensure -c is before -s or -S.\n");
> +
[...]
> +	if (core_parsed && taken_lcore_count != count) {
> +		RTE_LOG(ERR, EAL,
> +			"Warning: not all service cores were in the coremask - ensure -c or -l includes service cores\n");
> +	}

Sometimes, messages are split with a dot, sometimes with a dash.
Please choose only one for consistency (I prefer dot).
I think you can split the string and wrap the line at the end of the sentence.




More information about the dev mailing list