[dpdk-dev] [PATCH v4 12/23] rte_mbuf.h: explicit cast for size type to uint32
Bruce Richardson
bruce.richardson at intel.com
Thu May 17 12:53:54 CEST 2018
On Mon, May 14, 2018 at 01:10:27PM +0800, Andy Green wrote:
> Signed-off-by: Andy Green <andy at warmcat.com>
> ---
> lib/librte_mbuf/rte_mbuf.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
> index 0580ec8a0..169f3d3b0 100644
> --- a/lib/librte_mbuf/rte_mbuf.h
> +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -1577,7 +1577,7 @@ static inline void rte_pktmbuf_detach(struct rte_mbuf *m)
> __rte_pktmbuf_free_direct(m);
>
> priv_size = rte_pktmbuf_priv_size(mp);
> - mbuf_size = sizeof(struct rte_mbuf) + priv_size;
> + mbuf_size = (uint32_t)sizeof(struct rte_mbuf) + priv_size;
> buf_len = rte_pktmbuf_data_room_size(mp);
>
> m->priv_size = priv_size;
>
It would be good to include the error message in the commit log.
Also, for safety, is it better to have extra braces to cast the whole
expression, not just the sizeof, i.e.
mbuf_size = (uint32_t)(sizeof(...) + priv_size);
/Bruce
More information about the dev
mailing list