[dpdk-dev] [PATCH v5 00/21] Fixes for GCC8 against lagopus

Thomas Monjalon thomas at monjalon.net
Mon May 21 00:18:56 CEST 2018


> Andy Green (21):
>       lib/librte_ethdev: change eth-dev-ops API to return int
>       rte_string_fns.h: fix gcc8.1 sign conv warning in lstrcpy
>       lib/librte_eal: explicit tmp cast
>       /lib/librte_eal: stage cast from uint64 to long
>       rte_ring_generic.h: stack declarations before code
>       rte_ring.h: remove signed type flipflopping
>       rte_mbuf.h: avoid warnings from inadvertant promotion
>       rte_mbuf.h: explicit casts for int16 to uint16
>       rte_mbuf.h: make sure RTE-MIN compares same types
>       rte_mbuf.h: explicit cast restricting ptrdiff to uint16
>       rte_ether.h: explicit cast avoiding truncation warning
>       rte_rwlock.h: gcc8 sign conversion warnings
>       rte_ip.h: cast input to bswap16 to be uint16
>       rte_ip.h: cast around promotion to int
>       rte_ip.h: cast type decided by sizeof to uint32
>       rte_ip.h: cast return checksum size to uint16
>       rte_ip.h: cast away gcc8 warning on rte_ipv6_phdr_cksum
>       rte_mbuf.h: explicit cast for size type to uint32
>       rte_mbuf.h: explicit casts to uint16 to avoid warnings
>       rte_ethdev.h: align sign and scope of temp var
>       rte_byteorder.h: explicit cast for return promotion

16 patches have been applied.
The tags Fixes and Cc:stable have been added, so they can be backported.

5 patches are missing:
	lib/librte_eal: explicit tmp cast
	rte_rwlock.h: gcc8 sign conversion warnings
	rte_ip.h: cast type decided by sizeof to uint32
	rte_mbuf.h: explicit casts to uint16 to avoid warnings
	rte_ethdev.h: align sign and scope of temp var
Those patches are either not reviewed, or not safe enough at this release stage.
Please, feel free to send them again in a v6 to make clear they need more review.
I think the mbuf one (for uint16_t) may deserve to be split.

Thanks




More information about the dev mailing list