[dpdk-dev] [PATCH] net/e1000 igb: fix compile issue with log register

[Zhang, Helin]

> -----Original Message-----
> From: Varghese, Vipin
> Sent: Monday, May 21, 2018 6:10 PM
> To: Van Haaren, Harry; dev at dpdk.org
> Cc: Lu, Wenzhuo; Zhang, Helin
> Subject: RE: [PATCH] net/e1000 igb: fix compile issue with log register
> 
> 
> > -----Original Message-----
> > From: Van Haaren, Harry
> > Sent: Monday, May 21, 2018 3:02 PM
> > To: dev at dpdk.org
> > Cc: Van Haaren, Harry <harry.van.haaren at intel.com>; Varghese, Vipin
> > <vipin.varghese at intel.com>; Lu, Wenzhuo <wenzhuo.lu at intel.com>; Zhang,
> > Helin <helin.zhang at intel.com>
> > Subject: [PATCH] net/e1000 igb: fix compile issue with log register
> >
> > This commit fixes a compilation error if EM_PMD is not defined, bug
> > IGB_PMD is. The root cause of the issue was that log init variables
> > are declared as extern in a header file, while the definition of the variables
> was in e1000_ethdev.c.
> > Hence, the definitions were not available if the e1000 PMD is disabled.
> >
> > To fix this, a new file is added e1000_logs.c, which matches the
> > e1000_logs.h header. The log variables are always compiled in, but the
> > PMD logs are only registered if a PMD is enabled in the configuration.
> > Extra checks are added in order to avoid duplicate registering.
> >
> > Fixes: ed5bbb767c3e ("net/e1000: implement dynamic logging")
> >
> > Reported-by: Vipin Varghese <vipin.varghese at intel.com>
> > Signed-off-by: Harry van Haaren <harry.van.haaren at intel.com>
> Acked-by: Vipin Varghese <vipin.varghese at intel.com>
Applied to dpdk-next-net-intel, thanks!

/Helin