[dpdk-dev] [dpdk-stable] [PATCH] drivers/raw/ifpga_rawdev: fix coverity issue

Xu, Rosen rosen.xu at intel.com
Tue May 22 12:42:50 CEST 2018


Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas at monjalon.net]
> Sent: Monday, May 21, 2018 22:23
> To: Xu, Rosen <rosen.xu at intel.com>
> Cc: dev at dpdk.org; Zhang, Roy Fan <roy.fan.zhang at intel.com>; Doherty,
> Declan <declan.doherty at intel.com>; Richardson, Bruce
> <bruce.richardson at intel.com>; shreyansh.jain at nxp.com; Yigit, Ferruh
> <ferruh.yigit at intel.com>; Ananyev, Konstantin
> <konstantin.ananyev at intel.com>; Zhang, Tianfei <tianfei.zhang at intel.com>;
> Liu, Song <song.liu at intel.com>; Wu, Hao <hao.wu at intel.com>;
> gaetan.rivet at 6wind.com
> Subject: Re: [dpdk-stable] [PATCH] drivers/raw/ifpga_rawdev: fix coverity
> issue
> 
> 16/05/2018 15:53, Rosen Xu:
> > Fix coverity issue: 279449
> >
> > Signed-off-by: Rosen Xu <rosen.xu at intel.com>
> >
> > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver")
> > Coverity issue: 279449
> > Cc: stable at dpdk.org
> 
> Not for stable
> 
> > --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> > +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> > @@ -227,7 +227,7 @@
> >  	int file_fd;
> >  	int ret = 0;
> >  	ssize_t buffer_size;
> > -	void *buffer;
> > +	void *buffer = NULL;
> 
> It is not fixing anything.
> This variable cannot be read before being written.

Yes, it's a scripts error.
This patch can be cancelled.
 



More information about the dev mailing list