[dpdk-dev] [PATCH] net/mlx5: only register memory callback when probing a device

David Marchand david.marchand at 6wind.com
Wed May 30 18:04:31 CEST 2018


On Wed, May 30, 2018 at 5:59 PM, Yongseok Koh <yskoh at mellanox.com> wrote:
>> On May 30, 2018, at 7:42 AM, David Marchand <david.marchand at 6wind.com> wrote:
>>
>> The callback should be invoked only for memory that has been registered
>> in a device, hence, no need to track cleanup events if no device is
>> present.
>>
>> Bugzilla-ID: 56
>> Fixes: 974f1e7ef146 ("net/mlx5: add new memory region support")
>>
>> Signed-off-by: David Marchand <david.marchand at 6wind.com>
>> ---
>
> Good finding! Thank you so much for the patch.
> Patch is good. Just to be sure, I've run traffic with testpmd and also run
> multi-process test examples with traffic. It runs well.
>
> Acked-by: Yongseok Koh <yskoh at mellanox.com>

Well, this is a quick fix, the mlx5_prepare_shared_data() now does
more than initialising the shared data...
Might be better to revisit later, but this should do the job for 18.05.

Thanks.

-- 
David Marchand


More information about the dev mailing list