[dpdk-dev] [PATCH v2] app/proc-info:fix port mask parse bug

[Pattan, Reshma]

Hi,

> -----Original Message-----
> From: Li Han [mailto:han.li1 at zte.com.cn]
> Sent: Tuesday, November 6, 2018 3:04 AM
> To: Pattan, Reshma <reshma.pattan at intel.com>
> Cc: dev at dpdk.org; Li Han <han.li1 at zte.com.cn>
> Subject: [PATCH v2] [dpdk-dev] app/proc-info:fix port mask parse bug
> 
> parse_portmask return type is int,but global variable "enabled_port_mask" type
> is uint32_t.so in proc_info_parse_args function,when parse_portmask return -
> 1,"enabled_port_mask" will get a huge value and "if (enabled_port_mask == 0)"
> will never happen.

1) Please add Fixes line for the commit id that introduced this bug. 
Refer below link to know  more on Fixes line, http://doc.dpdk.org/guides/contributing/patches.html
Ex: Fixes: commit id ("commit message")

2) Title of the patch just can be  "fix port mask parsing".  No need to say bug. 
	And give space after  ': ' in the heading.

When I ran below script after applying your patches above 2 issues been reported, so you should make sure to run the below script before sending the patch. 

$devtools/check-git-log.sh
Wrong headline format:
        app/proc-info:fix port mask parse bug
Missing 'Fixes' tag:
        app/proc-info:fix port mask parse bug

Other than that , Please keep my ack in next version

Acked-by: Reshma Pattan <reshma.pattan at intel.com>

Thanks,
Reshma