[dpdk-dev] [PATCH 2/3] crypto/octeontx: fix null pointer dereferencing
Joseph, Anoob
Anoob.Joseph at cavium.com
Mon Nov 12 12:23:50 CET 2018
Hi Akhil,
You can squash the entire series. Or should I send a revised patch? Either way is fine.
Anoob
> -----Original Message-----
> From: Akhil Goyal <akhil.goyal at nxp.com>
> Sent: 12 November 2018 16:51
> To: Joseph, Anoob <Anoob.Joseph at cavium.com>; Pablo de Lara
> <pablo.de.lara.guarch at intel.com>
> Cc: Joseph, Anoob <Anoob.Joseph at cavium.com>; Jacob, Jerin
> <Jerin.JacobKollanukkaran at cavium.com>; Athreya, Narayana Prasad
> <NarayanaPrasad.Athreya at cavium.com>; Dwivedi, Ankur
> <Ankur.Dwivedi at cavium.com>; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 2/3] crypto/octeontx: fix null pointer
> dereferencing
>
> External Email
>
> Hi Anoob,
>
> On 11/11/2018 8:54 PM, Anoob Joseph wrote:
> > Fixes: bfe2ae495ee2 ("crypto/octeontx: add PMD skeleton")
> >
> > Signed-off-by: Anoob Joseph <anoob.joseph at caviumnetworks.com>
> > ---
> > drivers/crypto/octeontx/otx_cryptodev.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/crypto/octeontx/otx_cryptodev.c
> b/drivers/crypto/octeontx/otx_cryptodev.c
> > index 269f045..b201e0a 100644
> > --- a/drivers/crypto/octeontx/otx_cryptodev.c
> > +++ b/drivers/crypto/octeontx/otx_cryptodev.c
> > @@ -100,8 +100,8 @@ otx_cpt_pci_remove(struct rte_pci_device *pci_dev)
> > if (rte_eal_process_type() == RTE_PROC_PRIMARY)
> > rte_free(cryptodev->data->dev_private);
> >
> > - cryptodev->device = NULL;
> > cryptodev->device->driver = NULL;
> > + cryptodev->device = NULL;
> > cryptodev->data = NULL;
> >
> > /* free metapool memory */
> Can we squash the entire series into a single patch or at least 2/3 and
> 3/3 should be merged.
> You can have more than one fixes lines in a single patch.
>
> -Akhil
More information about the dev
mailing list