[dpdk-dev] [PATCH v2] eal: fix duplicate function declaration

Thomas Monjalon thomas at monjalon.net
Sun Nov 18 13:41:38 CET 2018


14/11/2018 12:24, Burakov, Anatoly:
> On 14-Nov-18 11:20 AM, Kevin Laatz wrote:
> > The rte_eal_get_runtime_dir() function is currently being declared in two
> > header files.
> > 
> > This API was made public in commit 6911c9fd8fbe ("eal: export function to
> > get runtime directory"), adding it to rte_eal.h. To make it public, the
> > 'rte' prefix was added to the function so it needed to be modified in the
> > original location of the declaration, eal_filesystem.h.  By only modifying,
> > and not removing the decalration, it is now a duplicate.
> > 
> > This patch removes the declaration from eal_filesystem.h.
> > 
> > Fixes: 6911c9fd8fbe ("eal: export function to get runtime directory")
> > 
> > Reported-by: Anatoly Burakov <anatoly.burakov at intel.com>
> > Signed-off-by: Kevin Laatz <kevin.laatz at intel.com>
> > 
> > ---
> > v2:
> >     - Fix commit message (checkpatch warning)
> > ---
> 
> I was too late to ack the first one...
> 
> Acked-by: Anatoly Burakov <anatoly.burakov at intel.com>

Applied, thanks





More information about the dev mailing list