[dpdk-dev] [PATCH] dev: fix devargs memleak on IPC detach request

Zhang, Qi Z qi.z.zhang at intel.com
Fri Nov 23 20:17:18 CET 2018



> -----Original Message-----
> From: Stojaczyk, Dariusz
> Sent: Friday, November 23, 2018 6:11 AM
> To: dev at dpdk.org
> Cc: thomas at monjalon.net; Stojaczyk, Dariusz <dariusz.stojaczyk at intel.com>;
> Zhang, Qi Z <qi.z.zhang at intel.com>
> Subject: [PATCH] dev: fix devargs memleak on IPC detach request
> 
> Device detach triggered through IPC leaked some memory.
> It allocated a devargs objects just to use it for parsing the devargs string in order
> to retrieve the device name. Those devargs weren't passed anywhere and were
> never freed.
> 
> First of all, let's put those devargs on the stack, so they doesn't need to be freed.
> Then free the additional arguments string as soon as it's allocated, because we
> won't need it.
> 
> Fixes: ac9e4a17370f ("eal: support attach/detach shared device from
> secondary")
> Cc: qi.z.zhang at intel.com
> 
> Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk at intel.com>

Acked-by: Qi Zhang <qi.z.zhang at intel.com>

Thanks
Qi




More information about the dev mailing list