[dpdk-dev] [PATCH 2/3] app/compress-perf: add performance measurement

[Trahe, Fiona]

Hi Shally, Lee,

> -----Original Message-----
> From: Daly, Lee
> Sent: Monday, October 15, 2018 8:10 AM
> To: Verma, Shally <Shally.Verma at cavium.com>
> Cc: Jozwiak, TomaszX <tomaszx.jozwiak at intel.com>; dev at dpdk.org; Trahe, Fiona
> <fiona.trahe at intel.com>; akhil.goyal at nxp.com
> Subject: RE: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance measurement
> 
> Thanks for your input Shally see comments below.
> 
> 
> I will be reviewing these changes while Tomasz is out this week.
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Verma, Shally
> > Sent: Friday, October 12, 2018 11:16 AM
> > To: Jozwiak, TomaszX <tomaszx.jozwiak at intel.com>; dev at dpdk.org; Trahe,
> > Fiona <fiona.trahe at intel.com>; akhil.goyal at nxp.com; De Lara Guarch, Pablo
> > <pablo.de.lara.guarch at intel.com>
> > Cc: De at dpdk.org; Lara at dpdk.org; Guarch at dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance
> > measurement
> >
///

> >Also, why do we need --max-num-
> > sgl-segs as an input option from user? Shouldn't input_sz and seg_sz
> > internally decide on num-segs?
> > Or is it added to serve some other different purpose?
> Will have to get back to you on this one, seems illogical to get this input from user,
> But I will have to do further investigation to find if there was a different purpose.

[Fiona] Some PMDs have a limit on how many links can be in an sgl chain, e.g. in QAT case the 
PMD allocates a pool of internal structures of a suitable size during device initialisation, this is not 
a hard limit but can be configured in .config to give the user control over the memory resources allocated.
This perf-tool max-num-sgl-segs is so the user can pick a value <= whatever the PMD's max is.