[dpdk-dev] [PATCH v6 1/2] net/mlx5: support meson build

[Shahaf Shuler]

Thursday, September 13, 2018 3:42 PM, Bruce Richardson:
> Subject: Re: [PATCH v6 1/2] net/mlx5: support meson build
> 
> On Thu, Sep 13, 2018 at 03:11:05PM +0300, Shahaf Shuler wrote:
> > From: Nelio Laranjeiro <nelio.laranjeiro at 6wind.com>
> >
> > Compile Mellanox driver when its external dependencies are met.  A
> > glue version of the driver can still be requested by using the
> > -Denable_driver_mlx_glue=true
> >
> > To avoid modifying the whole sources and keep the compatibility with
> > current build systems (e.g. make), the mlx5_autoconf.h is still
> > generated by invoking DPDK scripts though meson's run_command()
> > instead of using has_types, has_members, ... commands.
> >
> 
> This part of the commit message is no longer accurate.
> 
> > Meson will try to find the required external libraries.  When they are
> > not installed system wide, they can be provided though CFLAGS, LDFLAGS
> > and LD_LIBRARY_PATH environment variables, example (considering
> > RDMA-Core is installed in /tmp/rdma-core):
> >
> >  # CLFAGS=-I/tmp/rdma-core/build/include \
> >    LDFLAGS=-L/tmp/rdma-core/build/lib \
> >    LD_LIBRARY_PATH=/tmp/rdma-core/build/lib \
> >    meson output
> >  # LD_LIBRARY_PATH=/tmp/rdma-core/build/lib \
> >    ninja -C output install
> >
> > Note: LD_LIBRARY_PATH before ninja is necessary when the meson
> > configuration has changed (e.g. meson configure has been called), in
> > such situation the LD_LIBRARY_PATH is necessary to invoke the
> > autoconfiguration script.
> >
> > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro at 6wind.com>
> > Acked-by: Bruce Richardson <bruce.richardson at intel.com>
> > Signed-off-by: Shahaf Shuler <shahafs at mellanox.com>
> 
> The signoffs should be together, followed by the ack.
> 
> Otherwise LGTM (for both patches)

Series applied to next-net-mlx with the above modification, thanks.

> 
> /Bruce