[dpdk-dev] [PATCH v8 08/10] eal: add minimum viable code for eal on windows

Pallavi Kadam pallavi.kadam at intel.com
Tue Apr 2 23:21:53 CEST 2019


On 4/2/2019 1:06 PM, Thomas Monjalon wrote:
> 02/04/2019 05:54, Anand Rawat:
>> Add windows specific logic for eal.c, eal_lcore.c,
>> eal_debug.c and eal_thread.c. Updated header files to
>> contain suitable function declaractions.
>>
>> Signed-off-by: Anand Rawat <anand.rawat at intel.com>
>> Signed-off-by: Pallavi Kadam <pallavi.kadam at intel.com>
>> Reviewed-by: Jeff Shaw <jeffrey.b.shaw at intel.com>
>> Reviewed-by: Ranjit Menon <ranjit.menon at intel.com>
>> ---
> [...]
>> +		/*
>> +		 * create communication pipes between master thread
>> +		 * and children
>> +		 */
>> +		if (_pipe(lcore_config[i].pipe_master2slave,
>> +			sizeof(char), _O_BINARY) < 0)
>> +			rte_panic("Cannot create pipe\n");
> rte_panic should be used only in applications, not in libraries.
> The application can do something in case of DPDK failure.
> Please remove all calls to rte_panic() during next weeks, thanks.

Ok, will try to incorporate in v9. Just curious, is this the major issue?

Calls to rte_panic() can be seen in linux/eal and freebsd/eal.

>
>


More information about the dev mailing list