[dpdk-dev] [PATCH v8 14/14] raw/ifpga_rawdev: add IPN3KE support for IFPGA Rawdev

[Xu, Rosen]

Hi Ferruh,

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Monday, April 15, 2019 20:29
> To: Xu, Rosen <rosen.xu at intel.com>; dev at dpdk.org
> Cc: Zhang, Tianfei <tianfei.zhang at intel.com>; Wei, Dan
> <dan.wei at intel.com>; Pei, Andy <andy.pei at intel.com>; Yang, Qiming
> <qiming.yang at intel.com>; Wang, Haiyue <haiyue.wang at intel.com>; Chen,
> Santos <santos.chen at intel.com>; Zhang, Zhang <zhang.zhang at intel.com>;
> Lomartire, David <david.lomartire at intel.com>; Hu, Jia <jia.hu at intel.com>
> Subject: Re: [PATCH v8 14/14] raw/ifpga_rawdev: add IPN3KE support for
> IFPGA Rawdev
> 
> On 4/15/2019 6:07 AM, Rosen Xu wrote:
> > Add Intel FPGA Acceleration NIC IPN3KE support for IFPGA Rawdev.
> >
> > Signed-off-by: Rosen Xu <rosen.xu at intel.com>
> > Signed-off-by: Tianfei Zhang <tianfei.zhang at intel.com>
> > Signed-off-by: Andy Pei <andy.pei at intel.com>
> 
> <...>
> 
> > @@ -128,6 +137,45 @@
> >  			return;
> >  		}
> >  	}
> > +
> > +	/* get opae_manager to rawdev */
> > +	mgr = opae_adapter_get_mgr(adapter);
> > +	if (mgr) {
> > +		//get LineSide BAR Index
> 
> Please prefer c89 comments, /* */

Fixed in v9.

> <...>
> 
> > +	}
> > +	if (!strcmp(attr_name, "NICSideLinkStatus")) {
> > +		/*
> > +		 *
> > +		 */
> 
> Please add some comments or drop.

Dropped in v9.

> > +		return 0;
> > +	}
> > +	if (!strcmp(attr_name, "NICSideBARIndex")) {
> > +		/* eth_group 1 on FPGA connect to NicSide */
> > +		if (opae_manager_get_eth_group_region_info(mgr, 1,
> > +			&opae_eth_grp_reg_info))
> > +			return -1;
> > +		*attr_value = (uint64_t)opae_eth_grp_reg_info.mem_idx;
> > +		return 0;
> > +	}
> > +
> > +	IFPGA_RAWDEV_PMD_ERR("attr_name not support");
> 
> It can be useful to print requested attr_name

Added in v9.

> <...>
> 
> > @@ -8,8 +8,8 @@
> >  extern int ifpga_rawdev_logtype;
> >
> >  #define IFPGA_RAWDEV_PMD_LOG(level, fmt, args...) \
> > -	rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "%s(): " fmt "\n", \
> > -				__func__, ##args)
> > +	rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "ifpga_rawdev: "
> fmt, \
> > +		##args)
> 
> Are you sure about this change? Another commit in this release [1] updates
> "ifgpa" -> "%s", __func__; but this commit revert it back to "ifpga_rawdev: "
> 
> [1]
> Fixes: a3a6a3d94f7e ("raw/ifpga: modify log output")
> Cc: andy.pei at intel.com

Thanks you reminder, dropped this change in v9.