[dpdk-dev] [PATCH 1/2] crypto/aesni_gcm: add dependency version check

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: Richardson, Bruce
> Sent: Friday, April 19, 2019 11:01 AM
> To: dev at dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>; Doherty,
> Declan <declan.doherty at intel.com>; Richardson, Bruce
> <bruce.richardson at intel.com>
> Subject: [PATCH 1/2] crypto/aesni_gcm: add dependency version check
> 
> The aesni_mb driver and the aesni_gcm driver both require the same version
> of the IPSec_MB library, but only the former has a check of the library found
> to see if it's the correct version. Add a similar check to the aesni_gcm
> library's meson.build file, so that the auto-detection of dependencies works
> correctly.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
> ---
>  drivers/crypto/aesni_gcm/meson.build | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/crypto/aesni_gcm/meson.build
> b/drivers/crypto/aesni_gcm/meson.build
> index 70f57ad73..7183cfcba 100644
> --- a/drivers/crypto/aesni_gcm/meson.build
> +++ b/drivers/crypto/aesni_gcm/meson.build

The patch looks good, but we should broaden its scope and also modify the Makefile,
to check for the library version, like in the aesni_mb PMD.

Could you add that check too?

Thanks!
Pablo