[dpdk-dev] [PATCH 19.08 4/6] ipc: handle unsupported ipc in sendmsg

Anatoly Burakov anatoly.burakov at intel.com
Thu Apr 25 14:45:17 CEST 2019


Currently, IPC API will silently ignore unsupported IPC.
Fix the API call and its callers to explicitly handle
unsupported IPC cases.

Signed-off-by: Anatoly Burakov <anatoly.burakov at intel.com>
---
 lib/librte_eal/common/eal_common_proc.c | 6 ++++++
 lib/librte_eal/common/include/rte_eal.h | 3 +++
 2 files changed, 9 insertions(+)

diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c
index 4c062a306..0db842f84 100644
--- a/lib/librte_eal/common/eal_common_proc.c
+++ b/lib/librte_eal/common/eal_common_proc.c
@@ -792,6 +792,12 @@ rte_mp_sendmsg(struct rte_mp_msg *msg)
 	if (!check_input(msg))
 		return -1;
 
+	if (internal_config.no_shconf) {
+		RTE_LOG(DEBUG, EAL, "No shared files mode enabled, IPC is disabled\n");
+		rte_errno = ENOTSUP;
+		return -1;
+	}
+
 	RTE_LOG(DEBUG, EAL, "sendmsg: %s\n", msg->name);
 	return mp_send(msg, NULL, MP_MSG);
 }
diff --git a/lib/librte_eal/common/include/rte_eal.h b/lib/librte_eal/common/include/rte_eal.h
index 7f807aa8e..d47cb2440 100644
--- a/lib/librte_eal/common/include/rte_eal.h
+++ b/lib/librte_eal/common/include/rte_eal.h
@@ -290,6 +290,9 @@ rte_mp_action_unregister(const char *name);
  * This function will send a message which will be responsed by the action
  * identified by name in the peer process.
  *
+ * @note IPC may be unsupported in certain circumstances, so caller should check
+ *    for ENOTSUP error.
+ *
  * @param msg
  *   The msg argument contains the customized message.
  *
-- 
2.17.1


More information about the dev mailing list