[dpdk-dev] [RFC] ethdev: add IPv4/IPv6 DSCP rewrite action

[Stephen Hemminger]

On Tue, 10 Dec 2019 10:33:28 +0300
Andrew Rybchenko <arybchenko at solarflare.com> wrote:

> > For some overlay network, such as VXLAN, the DSCP field in the new outer
> > IP header after VXLAN decapsulation may need to be updated accordingly.
> > 
> > This commit introduce the DSCP modify action for IPv4 and IPv6.
> > 
> > Signed-off-by: Suanming Mou <suanmingm at mellanox.com>  
> 
> Acked-by: Andrew Rybchenko <arybchenko at solarflare.com>
> 
> as usual it requires testpmd support and a driver which
> supports it (I understand that it may be omitted in RFC).

And it requires documentation and a software implementation in the flow
classifier.


Plus you conveniently exclude defining what happens to reserved bits.
"What ever our hardware does is correct" is not a useful answer.
You need to be precise and limited in what is allowed to make this usable.

Sorry, to be so negative. This feature is fine in itself and a useful
incremental improvement. But nobody has stepped up to address the usability
of rte_flow.