[dpdk-dev] [PATCH] eal: support strlcat function

Burakov, Anatoly anatoly.burakov at intel.com
Thu Jan 17 11:39:02 CET 2019


On 16-Jan-19 12:48 PM, Bruce Richardson wrote:
> Add the strlcat function to DPDK to exist alongside the strlcpy one.  While
> strncat is generally safe for use for concatenation, the API for the
> strlcat function is perhaps a little nicer to use, and supports truncation
> detection.
> 
> See commit: 5364de644a4b ("eal: support strlcpy function") for more
> details on the function selection logic, since we only should be using the
> DPDK-provided version when no system-provided version is present.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
> ---

<...>

>   static int
>   test_string_fns(void)
>   {
>   	if (test_rte_strsplit() < 0)
>   		return -1;
> +	if (test_rte_strlcat() < 0)
> +		return -1;
>   	return 0;
>   }
>   
> 

Unrelated, but do we also need to test strlcpy, strscpy and other 
functions that were introduced?

-- 
Thanks,
Anatoly


More information about the dev mailing list