[dpdk-dev] [PATCH v2 4/5] examples/vdpa: support building from pkg-config info

[Thomas Monjalon]

02/07/2019 16:35, Bruce Richardson:
> On Tue, Jul 02, 2019 at 09:57:48AM +0200, Thomas Monjalon wrote:
> > It seems "CFLAGS += -DALLOW_EXPERIMENTAL_API"
> > is reset by the call to pkg-config.
> >
> 
> No, it's not, it's reset by the call to the DPDK make build system in
> the other leg of the code. I'll fix this in the Makefile in v3.

OK
 
> > > +build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build
> > 
> > Better to use the real directory name as prerequisite,
> > instead of "build".
> > 
> Not sure what you mean here, build is the name of the directory. [This is
> also consistent with what is done in all the other example makefiles. If it
> needs updating, then it should be done as a general patch to all examples
> in 19.11 release timeframe.]

Ah my bad, I overlooked it :)