[dpdk-dev] [PATCH] net/i40e: fix flow double mark action error check

Zhang, Qi Z qi.z.zhang at intel.com
Fri Jul 26 06:48:15 CEST 2019



> -----Original Message-----
> From: Ergin, Mesut A
> Sent: Friday, July 26, 2019 5:51 AM
> To: Xing, Beilei <beilei.xing at intel.com>; Zhang, Qi Z <qi.z.zhang at intel.com>
> Cc: dev at dpdk.org; Van Haaren, Harry <harry.van.haaren at intel.com>; Ergin,
> Mesut A <mesut.a.ergin at intel.com>
> Subject: [PATCH] net/i40e: fix flow double mark action error check
> 
> This commit fixes an issue with the error checking in flow MARK action.
> Previously, (ANY + MARK) would fail, as the (mark_spec == 0) condition
> would cause an early error return, however really it is (mark_spec != 0) that
> should cause the early error return.
> 
> Flipping the binary comparison corrects the behaviour, and (ANY + MARK)
> now succeeds, while (MARK + MARK) fails.
> 
> Fixes: 0bbcfc706a2b ("net/i40e: support MARK and RSS flow action")
> 
> Suggested-by: Harry van Haaren <harry.van.haaren at intel.com>
> Signed-off-by: Mesut Ali Ergin <mesut.a.ergin at intel.com>
> ---

Acked-by: Qi Zhang <qi.z.zhang at intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi


More information about the dev mailing list