[dpdk-dev] [PATCH 0/6] HelloWorld example for Windows

[David Marchand]

On Fri, Mar 1, 2019 at 2:48 PM Bruce Richardson <bruce.richardson at intel.com>
wrote:

> On Thu, Feb 28, 2019 at 11:18:41PM -0800, Anand Rawat wrote:
> > Helloworld example for Windows.
> > Includes Windows-specific EAL changes and meson
> > changes to build the code on Windows.
> >
> > Anand Rawat (6):
> >   eal: eal stub to add windows support
> >   eal: Add header files to support windows
> >   eal: Add headers for compatibility with windows environment
> >   eal: add minimum viable code for eal on windows
> >   examples: Add meson changes for windows
> >   doc: add documention for windows
> >
> Thanks for this, it's good to see some progress here with small managable
> patches.
>
> I've just tried this on my laptop using clang + meson + ninja. I see some
> warnings at the link phase due to unknown flags, but otherwise things
> compile and link ok and I get helloworld app running and printing hello
> from all cores. Specifying a coremask doesn't seem to work though - perhaps
> something to look at for a V2.
>

Some easy warnings to fix:

[dmarchan at dmarchan dpdk]$ ./devtools/checkpatches.sh

### eal: eal stub to add windows support

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#402: FILE: lib/librte_eal/winapp/eal/eal_lcore.c:9:
+eal_cpu_core_id(unsigned lcore_id)

total: 0 errors, 1 warnings, 461 lines checked
Warning in /lib/librte_eal/winapp/eal/eal_debug.c:
Using rte_panic/rte_exit

### eal: add minimum viable code for eal on windows

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#239: FILE: lib/librte_eal/winapp/eal/eal_lcore.c:10:
+    unsigned numTotalProcessors;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#240: FILE: lib/librte_eal/winapp/eal/eal_lcore.c:11:
+    unsigned numProcessorSockets;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#241: FILE: lib/librte_eal/winapp/eal/eal_lcore.c:12:
+    unsigned numProcessorCores;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#242: FILE: lib/librte_eal/winapp/eal/eal_lcore.c:13:
+    unsigned reserved;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#280: FILE: lib/librte_eal/winapp/eal/eal_lcore.c:50:
+    unsigned lcore = 0;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#281: FILE: lib/librte_eal/winapp/eal/eal_lcore.c:51:
+    for (unsigned socket = 0; socket <

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#283: FILE: lib/librte_eal/winapp/eal/eal_lcore.c:53:
+        for (unsigned core = 0; core < (win_cpu_map.numProcessorCores /

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#304: FILE: lib/librte_eal/winapp/eal/eal_lcore.c:73:
+eal_cpu_detected(unsigned lcore_id)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#313: FILE: lib/librte_eal/winapp/eal/eal_lcore.c:80:
+eal_cpu_socket_id(unsigned lcore_id)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#320: FILE: lib/librte_eal/winapp/eal/eal_lcore.c:87:
+eal_cpu_core_id(unsigned lcore_id)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#348: FILE: lib/librte_eal/winapp/eal/eal_thread.c:15:
+RTE_DEFINE_PER_LCORE(unsigned, _lcore_id) = LCORE_ID_ANY;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#356: FILE: lib/librte_eal/winapp/eal/eal_thread.c:23:
+rte_eal_remote_launch(lcore_function_t *f, void *arg, unsigned slave_id)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#388: FILE: lib/librte_eal/winapp/eal/eal_thread.c:55:
+eal_thread_init_master(unsigned lcore_id)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#406: FILE: lib/librte_eal/winapp/eal/eal_thread.c:73:
+    unsigned lcore_id;

total: 0 errors, 14 warnings, 502 lines checked
Warning in /lib/librte_eal/winapp/eal/eal.c:
Using rte_panic/rte_exit

4/6 valid patches

[dmarchan at dmarchan dpdk]$ ./devtools/check-git-log.sh
Wrong headline uppercase:
    eal: Add header files to support windows
    eal: Add headers for compatibility with windows environment
    examples: Add meson changes for windows
Wrong tag:
    Signed-off-by: Kadam, Pallavi <pallavi.kadam at intel.com>
    Signed-off-by: Kadam, Pallavi <pallavi.kadam at intel.com>
    Signed-off-by: Kadam, Pallavi <pallavi.kadam at intel.com>
    Signed-off-by: Kadam, Pallavi <pallavi.kadam at intel.com>
    Signed-off-by: Kadam, Pallavi <pallavi.kadam at intel.com>
    Signed-off-by: Kadam, Pallavi <pallavi.kadam at intel.com>


-- 
David Marchand