[dpdk-dev] [PATCH 4/4] net/failsafe: support secondary process

Thomas Monjalon thomas at monjalon.net
Tue Mar 5 11:00:50 CET 2019


05/03/2019 10:33, Raslan Darawsheh:
> Hi Stephen, 
> 
> From: Stephen Hemminger <stephen at networkplumber.org>
> > On Thu, 28 Feb 2019 15:49:28 +0000
> > Raslan Darawsheh <rasland at mellanox.com> wrote:
> > 
> > > +		eth_dev->rx_pkt_burst =
> > (eth_rx_burst_t)&failsafe_rx_burst;
> > > +		eth_dev->tx_pkt_burst =
> > (eth_tx_burst_t)&failsafe_tx_burst;
> > 
> > Why is cast necessary here. The function signature should match.
> 
> I don't think it's necessary, but this is the same as the primary process implementation

If it's not necessary, better to not add them.
Don't worry about consistency for pointer casting :)




More information about the dev mailing list