[dpdk-dev] [PATCH v3] net/nfb: new netcope driver

Luca Boccassi bluca at debian.org
Wed Mar 6 14:25:21 CET 2019


On Wed, 2019-03-06 at 15:51 +0100, Rastislav Černay wrote:
> > 
> > --Why is -lfdt added? I don't see any symbols from libfdt used in
> > the
> > --rest of the patch?
> > 
> 
> Hi,
> libnfb is dependent on fdt and there is a special case, where some
> functions are defined in header (netcope/rxmac.h, netcope/txmac.h).
> So if one wants to use functions, from these headers fdt needs to be
> linked
> manually, not just through nfb. I also added fdt to meson.build
> so it is little clearer, however if libnfb is installed libfdt is
> always
> installed too.

This is a perfect use case for pkg-config. Please consider shipping a
libnfb.pc file in libnfb, so that you can define a Libs.private: -fdt
and users don't have to worry about these things themselves.

-- 
Kind regards,
Luca Boccassi


More information about the dev mailing list