[dpdk-dev] [dpdk-stable] [PATCH v4] drivers: fix possible overflow with strcat
Ferruh Yigit
ferruh.yigit at intel.com
Wed Mar 6 19:14:24 CET 2019
<...>
> @@ -11734,13 +11735,14 @@ static const char *get_bnx2x_flags(uint32_t flags)
>
> for (i = 0; i < 5; i++)
> if (flags & (1 << i)) {
> - strcat(flag_str, flag[i]);
> + strlcat(flag_str, flag[i], sizeof(flag_str));
> flags ^= (1 << i);
> }
> if (flags) {
> static char unknown[BNX2X_INFO_STR_MAX];
> snprintf(unknown, 32, "Unknown flag mask %x", flags);
> strcat(flag_str, unknown);
> + strlcat(flag_str, unknown, sizeof(flag_str));
Intention is to replace the 'strcat' right, seems missed to remove old code.
More information about the dev
mailing list